On Tue, 4 Apr 2023 01:49:09 GMT, Tyler Steele <tste...@openjdk.org> wrote:
>> Minor changes to the build system to recognize and warn that an incompatible >> toolchain is detected. > > Tyler Steele has updated the pull request incrementally with one additional > commit since the last revision: > > Change min xlx FP level to 11 LGTM. However I am not sure about the number extraction itself on AIX, maybe you could check this please ? #!/bin/sh COMPILER_VERSION_OUTPUT=`xlC -qversion 2>&1` COMPILER_VERSION_NUMBER=`echo $COMPILER_VERSION_OUTPUT | sed -e 's/^.*Version: (@<:@1-9@:>@@<:@0-9.@:>@*).*$/\1/'` echo $COMPILER_VERSION_OUTPUT echo $COMPILER_VERSION_NUMBER gives me IBM XL C/C++ for AIX, V16.1.0 (5725-C72, 5765-J12) Version: 16.01.0000.0013 IBM XL C/C++ for AIX, V16.1.0 (5725-C72, 5765-J12) Version: 16.01.0000.0013 So I wonder does the version number extraction really work on AIX ? ------------- Marked as reviewed by mbaesken (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13086#pullrequestreview-1395173662
