> This is an attempt to fix the issue on Windows when no cygwin Git is > installed or the Git for Windows installation has precedence in PATH lookup. > The path to the Windows GIT installation usually resides in `C:\Program > Files` which contains a space and thus needs some special handling. > > There exists code in `UTIL_LOOKUP_PROGS`/`UTIL_FIXUP_EXECUTABLE` that would > handle this. However, it relies on initializations made in > `PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET` and `BASIC_SETUP_PATHS`. Currently, > `UTIL_LOOKUP_PROGS(GIT, git)` is called too early in configure and hence the > problematic Windows path is not handled correctly. My fix makes sure that > only the barely necessary tool lookups required for > `PLATFORM_SETUP_OPENJDK_BUILD_AND_TARGET` and `BASIC_SETUP_PATHS` are made in > `BASIC_SETUP_FUNDAMENTAL_TOOLS` and everything else is moved into another > macro called `BASIC_SETUP_TOOLS` that is invoked after path handling is set > up correctly, which includes the lookup of git.
Christoph Langer has updated the pull request incrementally with one additional commit since the last revision: Adjust comments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13629/files - new: https://git.openjdk.org/jdk/pull/13629/files/e4890a96..0f875899 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13629&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13629&range=00-01 Stats: 5 lines in 3 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/13629.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13629/head:pull/13629 PR: https://git.openjdk.org/jdk/pull/13629
