On Fri, 28 Apr 2023 19:40:34 GMT, Erik Joelsson <er...@openjdk.org> wrote:

> I think it would be rather beneficial if this linking step could be performed 
> by some variant of SetupNativeCompilation. We don't want to have to maintain 
> logic for dealing with different platforms and linkers outside of the common 
> files if it can be helped. SetupNativeCompilation would need to be tweaked to 
> run without SRC and just a set of .a files.
>
> The error about platform support should be handled in configure. We shouldn't 
> be able to get here unless the configuration is expected to be supported.

All sounds good, thanks. I plan to withdraw this PR and extract the .a handling 
part into a new PR for now (as mentioned in response to @AlanBateman's 
comments). For the linking part, it would be good to have your close/direct 
involvement and collaboration in branch.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13709#discussion_r1180891458

Reply via email to