On Thu, 20 Apr 2023 02:32:37 GMT, Chen Liang <li...@openjdk.org> wrote:
> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. > The root cause might be that JMH requires passing VM args to benchmarks in > quotes, which might have triggered incorrect detections in `FIXPATH` (as in > comparison, `$1_MICRO_JAVA_OPTIONS += > --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to > work fine) > Also removed a useless and wrong Java flag to the java running javac, > originally intended to enable running `make test TEST="loom.obsolete"` > benchmarks. > > Since I only have a windows cygwin environment, I am not quite sure if this > works elsewhere. Since I have WSL setup [fixed](https://mail.openjdk.org/pipermail/build-dev/2023-May/039249.html), I have tested this patch in cygwin, wsl 1, and a linux target wsl 2 environments. All three runs normally. This patch is indeed ugly, but I don't think we have reliable ways to tell FixPath to only consider a space part of a Windows directory name when it's quoted, especially quotes can be further complicated by escapes. Thus I just did the simple, by exporting the needed functionalities and replace the needed parts for jmh invocation. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13550#issuecomment-1538964852
