On Tue, 9 May 2023 07:27:46 GMT, Kim Barrett <[email protected]> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Workaround failed reservation in ZForwardingTest
>
> src/hotspot/share/code/relocInfo.hpp line 1105:
>
>> 1103: int offset() override { ShouldNotReachHere();
>> return 0; }
>> 1104: address value() override { ShouldNotReachHere();
>> return nullptr; }
>> 1105: void set_value(address value) override { ShouldNotReachHere(); }
>
> Why is barrier_Relocation derived from DataRelocation? It seems to be
> overriding the entire virtual
> API associated with DataRelocation with ShouldNotReachHere implementations?
That is a good question. I think we used to use Relocation::
pd_address_in_code, which on x86 asserts that it has to be a DataRelocation.
But it seems like we are not using that any more and it just looks weird. I
will remove this and inherit from Relocation instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13771#discussion_r1188403500
