On Tue, 9 May 2023 22:14:04 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> I think you also need to make a change to `GraalBuilderImage.gmk` and the > target in `Main.gmk` that calls it. Good catch! Fixed `GraalBuilderImage.gmk`, thanks! For the `graal-builder-image` target that uses `GraalBuilderImage.gmk`, it's already changed to use `static-libs-graal-image` as one of the DEPS. Please let me know if anything additional that I missed. > make/Main.gmk line 1281: > >> 1279: all-bundles: product-bundles test-bundles docs-bundles >> static-libs-bundles >> 1280: >> 1281: ALL_TARGETS += buildtools hotspot hotspot-libs hotspot-static-libs >> hotspot-gensrc gensrc gendata \ > > Can you add a newline to try to keep line length in check here. No need to > reformat the whole block, just don't let random lines shoot way over 80. Done, thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13768#issuecomment-1540998009 PR Review Comment: https://git.openjdk.org/jdk/pull/13768#discussion_r1189206701
