On Wed, 10 May 2023 11:01:24 GMT, JoKern65 <d...@openjdk.org> wrote: > The new xlc17 compiler should be supported to build OpenJDK on AIX. This > compiler, compared to the currently supported xlc16, has a significantly more > recent clang (xlc 17.1.1 uses clang 15) included. > 1. Because the frontend interface of the new compiler (c-flags, Ld-Flags) has > changed from an xlc to a clang interface we decided to use the clang > toolchain for the new xlc17 compiler. > 2. Unfortunately, the system headers are mainly unchanged, so they do not > harmonize with the src/hotspot/share/utilities/globalDefinitions_gcc.hpp > which would be used if we totally switch to clang toolchain. So we keep the > HOTSPOT_TOOLCHAIN_TYPE=xlc > 3. In src/hotspot/share/utilities/globalDefinitions_xlc.hpp we introduce a > new define AIX_XLC_GE_17 which is set if we build with the new xlc17 on AIX. > This define will be used in following PRs.
src/hotspot/share/utilities/globalDefinitions_xlc.hpp line 1: > 1: /* #if __open_xl_version__ < 17 #error "xlc < 16 not supported" #endif Should this be xlc < 17 in the error ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13898#discussion_r1189887724