On Tue, 23 May 2023 18:02:16 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Give subclass priority
>
> src/java.base/share/classes/jdk/internal/misc/MainMethodFinder.java line 129:
>
>> 127: * @throws NoSuchMethodException when not preview and no method
>> found
>> 128: */
>> 129: public static Method findMainMethod(Class<?> mainClass) throws
>> NoSuchMethodException {
>
> The latest iteration of changes removes the warning but the latest iteration
> of the JEP proposes a warning when an instance main or static no-args main is
> preferred over an inherited static main. Is it that the JEP is just running
> ahead a bit and the changes in the PR will catch up soon?
Yes. There is some juggling going on to get the code to align with the
requirement and the interpretation thereof.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1202804732
