On Thu, 18 May 2023 15:46:46 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Updated to use `int` to replace `size_t.`. Thank you for the catching. > > bufsize is size_t, so that's a comparison between signed and unsigned values, > which I think some compilers > will warn about. Maybe the preceding check for negative is getting rid of > that? But will that still occur in > a slowdebug build, or will the lack of optimization lead to a warning? @kimbarrett Did you have a chance to have another look? Please let me know if you prefer to the update that the returned value of snprintf() is not checked because the memory size has been checked previously. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13995#discussion_r1210598423
