On Thu, 1 Jun 2023 13:32:49 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Exit during initialization on unsupported platforms
>
> test/hotspot/jtreg/gc/shenandoah/TestEvilSyncBug.java line 33:
> 
>> 31:  * @modules java.base/jdk.internal.misc
>> 32:  *          java.management
>> 33:  * @run driver/timeout=480 TestEvilSyncBug 
>> -XX:ShenandoahGCHeuristics=aggressive
> 
> Probably fine, but why this change to non-generational testing? Will 
> aggressive heuristic sharpen the test?

We moved this argument from the source code (original line 64) to here so that 
we can invoke the test differently in generational mode.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1220410522

Reply via email to