On Thu, 22 Jun 2023 11:53:59 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
> The new code seems to accurately correspond to what the various > `*Instrumentor` classes were doing, so that is good. I agree with Alan that > potential exception that may arise when generating the event are an issue > (e.g. call to getRemoteAddress() or other getter that may make a check on the > socket state) - though that was already present in the original code. Maybe > that could be fixed here though. > In cases where the implRead/implWrite call throws an exception, shouldn't the > event contain that exception, or at least exception message? If it doesn't > should it be emitted at all, or should another event be emitted instead? An exception event will be emitted. The event is disabled by default, but there is ongoing work on a throttling mechanism, so it can be always-on. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14342#issuecomment-1602659051
