On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241: > >> 239: DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, >> \ >> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c >> := parentheses, \ >> 241: DISABLED_WARNINGS_gcc_X11SurfaceData.c := >> implicit-fallthrough pointer-to-int-cast, \ > > Suggestion: > > DISABLED_WARNINGS_gcc_GLXSurfaceData.c := unused-function, \ > DISABLED_WARNINGS_gcc_gtk2_interface.c := parentheses type-limits, \ > DISABLED_WARNINGS_gcc_gtk3_interface.c := parentheses type-limits > unused-function, \ > DISABLED_WARNINGS_gcc_OGLBufImgOps.c := format-nonliteral, \ > DISABLED_WARNINGS_gcc_OGLPaints.c := format-nonliteral, \ > DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c := parentheses, > \ > DISABLED_WARNINGS_gcc_X11SurfaceData.c := implicit-fallthrough > pointer-to-int-cast, \ Please remove the extra spaces. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14033#discussion_r1239364317
