On Wed, 8 Mar 2023 08:50:24 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to >> this one. >> >> Classfile API development is tracked at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch >> >> Development branch of consolidated JDK class files parsing, generating, and >> transforming is at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch >> >> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online >> API >> documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/internal/classfile/package-summary.html) >> is also available. >> >> Please take you time to review this non-trivial JDK addition. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > removed obsolete javadoc from implementation classes src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java line 139: > 137: Util.checkKind(op, Opcode.Kind.CONSTANT); > 138: if (op != Opcode.BIPUSH && op != Opcode.SIPUSH) > 139: throw new IllegalArgumentException(String.format("Wrong > opcode specified; found %s, expected BIPUSH or SIPUSH", op, op.kind())); IDEA shows warning here. Too many arguments for format string (found: 2, expected: 1) Seems op.kind() parameter is unused in the format string. And the same issue in `jdk.internal.classfile.instruction.ConstantInstruction#ofLoad` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10982#discussion_r1239565938
