On Fri, 30 Jun 2023 11:37:10 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> There are a few references to rt.jar in comments and in the codebase itself.
>> Some of them might be removed or adjusted.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> remove import
Looks good overall. I made a few suggestions.
test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach024/TestDescription.java
line 40:
> 38: * Agent's JAR file contains modified class
> java.util.TooManyListenersException (it is assumed
> 39: * that this class isn't loaded before agent is loaded), agent
> instantiates TooManyListenersException
> 40: * and checks that non-modified version of this class was loaded from
> jdk image (not from agent's JAR).
"from the jdk image"
test/jdk/com/sun/tools/attach/ProviderTest.java line 110:
> 108: public static void main(String args[]) throws Exception {
> 109: // deal with internal builds where classes are loaded from
> the
> 110: // 'classes' directory rather than the image modules file
"... rather than the runtime image"
test/langtools/tools/javap/4798312/JavapShouldLoadClassesFromRTJarTest.java
line 27:
> 25: * @test
> 26: * @bug 4798312
> 27: * @summary In Windows, javap doesn't load classes from image
"... from the runtime image"
-------------
Changes requested by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14593#pullrequestreview-1514576016
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1253140142
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1253141204
PR Review Comment: https://git.openjdk.org/jdk/pull/14593#discussion_r1253142105
