On Fri, 14 Jul 2023 08:19:54 GMT, Alan Bateman <al...@openjdk.org> wrote:

> We should be able to remove it from our tests too, looks like there are some 
> left overs in test/hotspot/jtreg/vmTestbase/nsk/jdi.

I had noticed those but wasn't sure if they should be included in this change. 
I'll remove them and run some tests and see how it goes.

> The changes makes me wonder if we should do the same for -Xdebug.

I had a quick look now and it looks like it's just being set and then ignored 
if `-Xdebug` is passed. There's an accessor method to get the set value but I 
don't see it being used anywhere. Plus, the comment where `-Xdebug` is handled 
states:
>     } else if (match_option(option, "-Xdebug")) {
>      // note this flag has been used, then ignore

Would you want me to include the deprecation (for removal) for that option in 
this same PR or should we do that separately?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14882#issuecomment-1635527599

Reply via email to