On Tue, 18 Jul 2023 18:21:54 GMT, Patricio Chilano Mateo <pchilanom...@openjdk.org> wrote:
>> [JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) modified >> print_jni_stack to print the native stack when there are no Java frames. To >> do that it used VMError::print_native_stack, however that function is only >> for platforms that support stack-walking by following frames, on other >> platforms (i.e. Windows and AIX) we need to use >> os::platform_print_native_stack. >> >> I'm not trying to consolidate the different versions of the stack printing >> code in this PR so that it is more easily backported to where >> [JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) was. >> >> The test has been updated to work on Windows (taking advantage of two other >> recent enhancements - see JBS for details). >> >> Testing: >> - tiers 1-3 (sanity) >> - TestNativeStack regression test >> >> Thanks > > Looks good to me. Oops! Thanks for the review @pchilano - sorry I initially missed seeing it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14862#issuecomment-1641368386
