On Wed, 26 Jul 2023 10:29:25 GMT, Andreas Steiner <d...@openjdk.org> wrote:
>> On AIX the 'nm' needs -X64 option. > > Andreas Steiner has updated the pull request incrementally with one > additional commit since the last revision: > > correction of comment No, I don't think flags-other.m4 is suited. If at all, it should be handled in toolchain.m4 if we understand the -X64 flag on AIX as unconditional for every nm call. Then we could also remove -X64 in JvmMapFile.gmk. Also, maybe we should check if we can remove BUILD_NM and/or unify BUILD_NM and NM - as I see it now, BUILD_NM is not used anywhere. But I don't know all the history and maybe I'm overseeing something. OTOH, this cleanup could be done in another PR. For now, the code as it is would be ok, too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15036#issuecomment-1651896284
