On Mon, 31 Jul 2023 05:07:42 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Try not to remove CCACHE_BASEDIR. > > Ah, these changes were done for better reproducible builds, I had completely > missed that. The relative paths mean that the compiled files aren't all using > different absolute paths in their macros and so on, making the build more > reproducible. Changing these would be rather problematic for a lot of things > unfortunately > > Edit: Nevermind, David beat me to it @TheShermanTanker made a suggestion: ifeq ($(call Or, $(if $(CCACHE), true), $(call equals $(ALLOW_ABSOLUTE_PATHS_IN_OUTPUT), false))-$(FILE_MACRO_CFLAGS), true-) I got it by mail but I do not see it here - has it been deleted? I admit I prefer how it is now, this oneliner looks a bit cryptic to me. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15080#issuecomment-1658289640
