On Tue, 25 Jul 2023 16:19:27 GMT, Jesse Glick <d...@openjdk.org> wrote:
> By the way the bots seem to contradict themselves: > > > Commit message must refer to an issue > > and a previous failing `jcheck-openjdk/jdk-14716` check run referred to a > _commit_ message. Yet > > > Please do not rebase or force-push to an active PR > > implies that there would be no way to correct a mistaken commit message! > Perhaps the bot messages should be adjusted to refer to the PR title, which I > think is what they are actual checking, rather than “the commit message” > (which is especially ambiguous if there are multiple commits). I can see how this looks confusing. Here is what's actually happening. The `jcheck` message "Commit message must refer to an issue" refers to the commit generated by the bot, as it would currently be integrated if the PR was integrated at that moment. For a standard PR (as in not a merge style PR) all commits in the source branch are collapsed and committed on top of the current HEAD of the target branch. The message is constructed from the PR title and other meta-data from the PR (reviewers, summary etc). So the interpretation of that message really should be "PR title must refer to an issue". Regarding this change, I think `CONTRIBUTING.md` was intentionally created as just a simple link to https://openjdk.org/contribute. It would be better to update the text on openjdk.org to reflect the current practice and processes. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14716#issuecomment-1669566039
