On Tue, 25 Jul 2023 12:00:56 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> In case of issues in the configure step, we run into error messages like this > : > > configure: Current directory is /openjdk/jdk_4/build_mymachine. > configure: Since this is not the source root, configure will output the > configuration here > configure: (as opposed to creating a configuration in > <src_root>/build/<conf-name>). > configure: However, this directory is not empty. This is not allowed, since > it could > configure: seriously mess up just about everything. > configure: Try 'cd /mysrcdir/jdk' and restart configure > configure: (or create a new empty directory and cd to it). > configure: error: Will not continue creating configuration in > /openjdk/jdk_4/build_mymachine > configure exiting with result code 1 > > Probably the check could be relaxed; it tests for 'if test ! -e > "$OUTPUTDIR/spec.gmk"; then ...' > but the non-existance of spec.gmk does not mean we are not in a build > directory. > We could additionally check for e.g. $OUTPUTDIR/configure-support/config.log > or something related to check if it is a build directory . This pull request has now been integrated. Changeset: 6e3cc131 Author: Matthias Baesken <mbaes...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/6e3cc131daa9f3b883164333bdaad7aa3a6ca018 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod 8312467: relax the builddir check in make/autoconf/basic.m4 Reviewed-by: clanger, erikj ------------- PR: https://git.openjdk.org/jdk/pull/15017
