On Wed, 9 Aug 2023 14:39:05 GMT, Jesse Glick <d...@openjdk.org> wrote:
>> @jaikiran in >> https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me >> to a resource I had not previously found. https://openjdk.org/contribute is >> fine at a high level but still says things like >> >>> When your change is ready, send a message to the appropriate development >>> list… >> >> which clearly predates Skara, and does not apparently link to anything more >> current. Whereas this >> https://github.com/openjdk/jdk/blob/master/doc/building.md is thorough and >> discoverable, finding accurate guidelines for proposing pull requests was >> tough. > > Jesse Glick has updated the pull request incrementally with one additional > commit since the last revision: > > Regnerated building.html with preferred pandoc version > > (cherry picked from commit 4e418ebfc0d80ba228760c5f6f5332470f3875ce) Looks good to me. I would prefer if another reviewer approves this change as well even though the bots might accept that only one reviewer approved. ------------- Marked as reviewed by jwilhelm (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14716#pullrequestreview-1569942228
