On Mon, 14 Aug 2023 22:18:56 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> This is a redo of [pull/14561](https://git.openjdk.org/jdk/pull/14561). The > change relaxes the prerequisites for the top level java.base-jmod target to > not include targets for jmods of upgradable modules. > > The problem with the previous fix was that jdk.jdeps, which is a non > upgradable module, depends on java.compiler, which is an upgradable module. > The jmod tool wants to resolve the complete module graph given to the > `--hash-modules` option and this failed with: > > Error: Resolution failed: Module java.compiler not found, required by > jdk.jdeps > > The fix is to modify the prerequisite list for the java.base-jmod target to > include the jmod targets of the transitive deps of all the non upgradable > modules. Marked as reviewed by alanb (Reviewer). I think this change makes sense. ------------- PR Review: https://git.openjdk.org/jdk/pull/15279#pullrequestreview-1578995587 PR Comment: https://git.openjdk.org/jdk/pull/15279#issuecomment-1679275935
