On Thu, 10 Aug 2023 20:31:20 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion > warnings in runtime code. This is the last one I'm going to do for runtime > for a while. > Tested with tier1-4. src/hotspot/share/utilities/elfFile.cpp line 1426: > 1424: return false; > 1425: } > 1426: _state->_discriminator = static_cast<uint32_t>(discriminator); @chhagedorn These fields are declared as 32 bits but are read out of the dwarf info as 64 bits. Should they be 64 bits? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1295772547
