On Fri, 25 Aug 2023 10:17:38 GMT, Ao Qi <[email protected]> wrote: > The `LOONGARCH` is not a macro that must be defined. It is not a C/C++ > pre-defined macro and is also not pre-defined in libraries such as libffi. > We'd better use a macro defined in jdk.
Two minor nits. make/autoconf/platform.m4 line 585: > 583: HOTSPOT_$1_CPU_DEFINE=S390 > 584: elif test "x$OPENJDK_$1_CPU" = xloongarch64; then > 585: HOTSPOT_$1_CPU_DEFINE=LOONGARCH64 Would you mind moving the preceding two lines for RISCV32 to after PPC32? https://github.com/openjdk/jdk/blob/master/make/autoconf/platform.m4#L570C1-L571C34 We only have Zero support for RISCV32 for now. Thanks. src/hotspot/os/linux/os_linux.cpp line 1731: > 1729: #elif (defined RISCV) > 1730: static Elf32_Half running_arch_code=EM_RISCV; > 1731: #elif (defined LOONGARCH64) Maybe we should also rename the `LOONGARCH` macro here at this line?https://github.com/openjdk/jdk/blob/master/src/hotspot/os/linux/os_linux.cpp#L1735 ------------- Changes requested by fyang (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15428#pullrequestreview-1597067831 PR Review Comment: https://git.openjdk.org/jdk/pull/15428#discussion_r1306594444 PR Review Comment: https://git.openjdk.org/jdk/pull/15428#discussion_r1306593785
