On Mon, 28 Aug 2023 02:26:30 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Sorry but looking at the hotspot part of this I do not like the code in > jvm.cpp at all - it is far too messy. I expected to see a simple interface to > os::dlopen which then handles all the platform specific issues. > > I'm also somewhat dubious about having all the JDK code use a VM interface > for this, The usual coupling to the VM is to just provide native > implementations of core library methods, not to have the VM provide a general > purpose utility interface like dynamic library loading. Hi David, so would you prefer to call into 'os::dll_load' (probably you meant that) instead ? That would indeed make the coding smaller and less 'messy' . However 'os::dll_load' has no flags parameter but uses a default, have to check if this might be a problem ... ------------- PR Comment: https://git.openjdk.org/jdk/pull/15264#issuecomment-1695142975
