On Fri, 25 Aug 2023 22:31:31 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> After [JDK-8313374](https://bugs.openjdk.org/browse/JDK-8313374), out of tree > incremental builds with ccache started failing. The rewriting of the > generated dependency (*.d) files creates object file paths with `/../` in > them which make does not match to other rules. I don't think we should apply > the rewriting when the build dir is outside CCACHE_BASEDIR. > > During review of [JDK-8313374](https://bugs.openjdk.org/browse/JDK-8313374) I > also noted that the CCACHE_BASEDIR should point to WORKSPACE_ROOT rather than > TOPDIR for ccache to work uniformly for OracleJDK and OpenJDK builds. > > Both of these issues are addressed with this patch. I have tried various > scenarios and it seems to be working for me, but would appreciate some more > verification by people using ccache. This pull request has now been integrated. Changeset: 69d1feb8 Author: Erik Joelsson <er...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/69d1feb83f0e1f411f3b62f74e1a488f0dd29b15 Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod 8315060: Out of tree incremental build fails with ccache Reviewed-by: kbarrett, dholmes ------------- PR: https://git.openjdk.org/jdk/pull/15434
