On Fri, 1 Sep 2023 15:11:17 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

>> After looking at the build results of a jdk22 build on RHEL 8.4 Linux 
>> ppc64le that uses a ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0
>> devkit we observed those unwanted paths in libsplashscreen.so .
>> See those objdump and ldd output :
>> 
>> objdump -x ./lib/libsplashscreen.so | grep PATH
>>   RUNPATH 
>> /mydevkitsfolder/devkits/ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0/ppc64le-linux-gnu/sysroot/usr/lib64:$ORIGIN
>> 
>> 
>> ldd ./lib/libsplashscreen.so
>> ldd: warning: you do not have execution permission for 
>> `./lib/libsplashscreen.so'
>>       . . .
>>                libX11.so.6 => 
>> /mydevkitsfolder/devkits/ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0/ppc64le-linux-gnu/sysroot/usr/lib64/libX11.so.6
>>  (0x00007fffa3920000)
>>                libXext.so.6 => 
>> /mydevkitsfolder/devkits/ppc64le-linux-gnu-to-ppc64le-linux-gnu-fedora27-gcc11.3.0/ppc64le-linux-gnu/sysroot/usr/lib64/libXext.so.6
>>  (0x00007fffa38e0000)
>>    . . .
>> 
>> These paths were introduced by the '-R' setting, but it seems to be highly 
>> dependent on the environment.  But the '-R' setting should better be avoided 
>> anyway when the devkit is used.
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   check for SYSROOT and xlib-setting

make/autoconf/lib-x11.m4 line 38:

> 36:     X_LIBS=
> 37:   else
> 38:     x_libraries_orig="$x_libraries"

This needs to capture the value from `with_x` as well. Both are variants of 
user input.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15534#discussion_r1313285908

Reply via email to