On Tue, 5 Sep 2023 21:10:47 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - 8315096: Allowed access modes in memory segment should depend on layout >> alignment >> >> Reviewed-by: psandoz >> - Add missing @implSpec to AddressLayout >> >> Reviewed-by: pminborg >> - Fix misc typos in FFM API javadoc >> >> Reviewed-by: jvernee >> - Clarify javadoc w.r.t. exceptions thrown by a memory access var handle >> (part two) >> >> Reviewed-by: pminborg >> - Clarify javadoc w.r.t. exceptions thrown by a memory access var handle >> >> Reviewed-by: jvernee > > src/java.base/share/classes/java/lang/foreign/MemoryLayout.java line 443: > >> 441: * >> 442: * {@snippet lang = "java": >> 443: * offset = this.offsetHandle(P).invokeExact(B, I1, I2, ... In); > > Suggestion: > > * O = this.offsetHandle(P).invokeExact(B, I1, I2, ... In); > > To align with the use of `O` later on. Good catch. The `O` later on was added separately, hence they are out of sync. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1317041205