On Fri, 15 Sep 2023 14:57:39 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment text > > src/utils/hsdis/capstone/hsdis-capstone.c line 153: > >> 151: cs_option(cs_handle, CS_OPT_SYNTAX, ops.intel_syntax ? >> CS_OPT_SYNTAX_INTEL : CS_OPT_SYNTAX_ATT); >> 152: >> 153: // Turn on SKIPDATA mode > > The comment is self-evident. > > Suggestion: > > // Turn on SKIPDATA mode to skip broken instructions, which are ubiquitous > in JIT-generated code. OK now? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15763#discussion_r1328514997
