On Mon, 18 Sep 2023 18:33:20 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This PR is to incorporate the latest Unicode 15.1, which was released >> yesterday. Besides the usual character data update, an upgraded >> implementation of RegEx which reflects the Indic Conjunct Break specified in >> the latest [Unicode Annex #29 ("Unicode Text >> Segmentation")](https://unicode.org/reports/tr29/) is included. A >> corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 10 additional commits since > the last revision: > > - Fix GensrcRegex.gmk > - Merge branch 'master' into JDK-8296246-Unicode15.1 > - Update > make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update > make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - TR29 final version > - .md file update > - Final 8/28 > - Draft 8/11 > - GenerateExtraProperties tool > - initial commit Looks good; Its not easy to map all the code changes to spec changes. src/java.base/share/classes/jdk/internal/util/regex/Grapheme.java line 41: > 39: * (http://www.unicode.org/reports/tr29/tr29-43.html) > 40: * > 41: * @spec http://www.unicode.org/reports/tr29/tr29-43.html Is the first link now redundant with the @spec link? ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15728#pullrequestreview-1633892125 PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330509464