On Wed, 20 Sep 2023 14:41:59 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused define > > src/java.base/windows/native/libjava/java_props_md.c line 214: > >> 212: HRESULT hr; >> 213: WCHAR *tmpPath = NULL; >> 214: hr = SHGetKnownFolderPath(&FOLDERID_Profile, >> KF_FLAG_DONT_VERIFY, NULL, &tmpPath); > > I'd say inline the variable declaration here as well > Suggestion: > > HRESULT hr = SHGetKnownFolderPath(&FOLDERID_Profile, > KF_FLAG_DONT_VERIFY, NULL, &tmpPath); (And you will have to remove the declaration from the line above) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15789#discussion_r1331745594
