On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620), > BuildMicrobenchmark.gmk has started printing warnings about overriding > targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in > combination with debug symbols on macos having the same filename as the dylib > itself. > > In this fix, I'm changing the CopyFiles to no longer flatten the file > structure. I'm also filtering the list of files to be copied to only include > files from the native output `lib` dir. This avoids having any files from the > support dir (e.g. dependency *.d files) from being copied into the test > image. The resulting native directory in the test-image ends up having all > native libraries in it, with debug symbols in their respective *.dSYM > sub-directories, as expected. Thanks for fixing this! ------------- Marked as reviewed by redestad (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15824#pullrequestreview-1635989262
