On Wed, 20 Sep 2023 03:51:20 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Daniel Jeliński has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert test changes > > make/modules/java.base/Lib.gmk line 55: > >> 53: LDFLAGS := $(LDFLAGS_JDKLIB) \ >> 54: $(call SET_SHARED_LIBRARY_ORIGIN), \ >> 55: LDFLAGS_windows := -delayload:secur32.dll -delayload:iphlpapi.dll \ > > Wonder if this could be `LDFLAGS_microsoft_windows` to emphasize the compiler > that this applies to @TheShermanTanker I understand where you are coming from, but as a matter of fact we still only support building on Windows with Visual Studio, and as long as we do, we only need to specify "windows" in situations like these. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15793#discussion_r1332812580
