On Fri, 29 Sep 2023 23:00:44 GMT, Vicente Romero <vrom...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> PreviewFeature annotated with JEP 457
>
> make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java line 476:
>
>> 474: throw parser.newError("is malformed");
>> 475: }
>> 476: } else if (token.equals("import")) {
>
> why was this change necessary?
It allows to use imports in module infos, so annotations do not need to use FQN.
> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line
> 34:
>
>> 32: import jdk.internal.javac.PreviewFeature;
>> 33:
>> 34: /**
>
> shouldn't we have the preview header applied to all these compilation units?:
>
>
> {@preview Associated with pattern matching for instanceof, a preview feature
> of the Java language.
I'm not aware of preview javadoc tag, could you point me to an example?
> src/java.base/share/classes/java/lang/classfile/Attributes.java line 174:
>
>> 172: public static final String NAME_RUNTIME_INVISIBLE_ANNOTATIONS =
>> "RuntimeInvisibleAnnotations";
>> 173:
>> 174: /** RuntimeInvisibleTypeAnnotations */
>
> this comment should probably be: RuntimeInvisibleParameterAnnotations
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342320443
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342347591
PR Review Comment: https://git.openjdk.org/jdk/pull/15706#discussion_r1342319521
