On Fri, 6 Oct 2023 13:01:03 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:
>> [JDK-8317340](https://bugs.openjdk.org/browse/JDK-8317340) introduced >> -pathmap'ing of VS_INCLUDE paths to enable reproducible Windows builds that >> are not dependent on the Visual Studio tooling install location. This >> however requires pathmap'ing the Windows long paths generated by the >> compiler, which is no easy task within WSL. >> >> This PR excludes the VS include pathmap'ing within WSL, which will mean for >> reproducible builds on WSL, the same VS install location must be used. > > Andrew Leonard has updated the pull request incrementally with one additional > commit since the last revision: > > 8317601: Windows build on WSL broken after JDK-8317340 > > Signed-off-by: Andrew Leonard <anleo...@redhat.com> Could you add a comment on the new UTIL_FIXUP_WIN_LONG_PATH macro that it only works in cygwin? ------------- PR Review: https://git.openjdk.org/jdk/pull/16069#pullrequestreview-1661805794
