On Fri, 6 Oct 2023 05:23:24 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Frederic Thevenet has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed further places where win symbol files names expected the old >> convention. > > make/CreateJmods.gmk line 83: > >> 81: ifneq ($(CMDS_DIR), ) >> 82: DEPS += $(call FindFiles, $(CMDS_DIR)) >> 83: ifeq ($(call isTargetOs, windows)+$(SHIP_DEBUG_SYMBOLS), true+public) > > Suggestion: > > ifeq ($(call isCompiler, microsoft)+$(SHIP_DEBUG_SYMBOLS), true+public) > > > stripped pdbs (and pdbs in general) are only ever used with the VS toolchain I understand the point of this change, but it is not directly related to the issue addressed here (i.e. this condition wasn't introduced in this PR.). Should it be included in the PR anyway? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16039#discussion_r1350034554
