On Thu, 12 Oct 2023 19:25:13 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:

> In GHA, the versions of macOS (note: the version used for build/test, **not** 
> the target macOS version we compile for) and Xcode are starting to show age. 
> It's time to update to more modern versions.
> 
> This change bumps the macOS to 13 (from 11) and Xcode to 14.3.1 (from 
> 12.5.1/11.7). This is a prerequisite change for JDK-8317970 / #16155, without 
> which the build SIGSEGVs (presumably some since-fixed issue in Xcode 12.5.1).

Marked as reviewed by erikj (Reviewer).

.github/workflows/test.yml line 135:

> 133:           # On macOS we need to install some dependencies for testing
> 134:           brew install make
> 135:           sudo xcode-select --switch 
> /Applications/Xcode_11.7.app/Contents/Developer

Interesting that this didn't match the version we are using. Someone more 
versed in GHA could perhaps make this use the `xcode-toolset-version` instead.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16171#pullrequestreview-1675066744
PR Review Comment: https://git.openjdk.org/jdk/pull/16171#discussion_r1357334876

Reply via email to