On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Port of miscellaneous leftover implementation-only changes from the >> panama-foreign repo: >> >> These four related to improving the performance of the internal `strlen` >> implementation: >> >> - https://github.com/openjdk/panama-foreign/pull/862 >> - https://github.com/openjdk/panama-foreign/pull/860 >> - https://github.com/openjdk/panama-foreign/pull/858 >> - https://github.com/openjdk/panama-foreign/pull/857 >> >> Adding new benchmarks: >> >> - https://github.com/openjdk/panama-foreign/pull/874 >> - https://github.com/openjdk/panama-foreign/pull/870 >> >> Other misc. changes: >> >> - https://github.com/openjdk/panama-foreign/pull/885 >> - https://github.com/openjdk/panama-foreign/pull/886 >> - https://github.com/openjdk/panama-foreign/pull/864 >> - https://github.com/openjdk/panama-foreign/pull/903 >> - https://github.com/openjdk/panama-foreign/pull/890 (note that this is a >> javadoc block in the implementation only) >> - https://github.com/openjdk/panama-foreign/pull/908 >> - https://github.com/openjdk/panama-foreign/pull/910 >> >> Testing: `jdk_foreign` > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > 8315041: Optimize Java to C string conversion by avoiding double copy > > Reviewed-by: pminborg > This seems to have been missed too? > [openjdk/panama-foreign#897](https://github.com/openjdk/panama-foreign/pull/897) I also don't see https://git.openjdk.org/panama-foreign/pull/894 Perhaps you are planning a different PR for "style" only changes? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16128#issuecomment-1761681674
