On Thu, 19 Oct 2023 01:26:43 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Review feedback >> - Merge branch 'JDK-8295159' of https://github.com/theRealAph/jdk into >> JDK-8295159 >> - Remove change to RestoreMXCSROnJNICalls > > src/hotspot/os/linux/os_linux.cpp line 1853: > >> 1851: >> 1852: #ifndef IA32 >> 1853: // Quickly test to make sure denormals are correctly handled. > > Nit: I recommend using "subnormal" rather than "denormal" for general > terminology on this point. While "denormal" was used in the original IEEE 754 > standard from 1985, subsequent iterations of the standard using "subnormal" > The term "subnormal" has also been used for the last several editions of JLS > and JVMS. I've long avoided "subnormal" because subnormal in British English, adjective 3. [old-fashioned, offensive] a person of low intelligence ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10661#discussion_r1365207067
