On Fri, 13 Oct 2023 16:28:19 GMT, Doug Simon <dnsi...@openjdk.org> wrote:
> The Graal code base has > [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) > its module to `jdk.compiler.graal` as part of preparations for Project > Galahad. Due to the way Java modules work, this requires a JDK change. The > core of the issue is that the > [service](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L37) > by which HotSpot requests a Graal compilation is defined in JVMCI. Since > JVMCI is in the boot layer, the service can only be implemented by a provider > in the boot layer and the package defining the service must be exported to > the provider's defining module. This export currently targets > [`jdk.internal.vm.compiler`](https://github.com/openjdk/jdk/blob/56aa1e8dc8047cbc29d554889c64beb6eca0b8eb/src/jdk.internal.vm.ci/share/classes/module-info.java#L28) > and so the binding fails for the new Graal module. To address this, this PR > reflects the Graal module rena ming, including adjusting the qualified export. Why you replaced pair of copyright years with one year in module-info.Java files? Instead of updating last year only. Why also update 'since' there? Even if you changed location these files existed already. ------------- Changes requested by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16189#pullrequestreview-1690172543
