On Mon, 30 Oct 2023 15:08:03 GMT, Julian Waters <jwat...@openjdk.org> wrote:

>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains 
>> all of the fixes required for HotSpot to compile under the stricter mode 
>> activated when the permissive- flag is passed
>> 
>> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to 
>> avoid goto jumping across uninitialized locals
>> - Adds a CAST_FROM_FN_PTR cast to the return value from ::signal to void, as 
>> they cannot be implicitly converted
>> - symbolengine.cpp's SimpleBufferWithFallback's templates cannot work with a 
>> raw char (Actual fix under discussion)
>> - Removed a throw() specification from a mismatched definition in 
>> allocation.cpp
>
> Julian Waters has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Change '\0' to 0 in symbolengine.cpp

Sorry, re-requesting reviews from all again, as well as permission for 
including -permissive- for HotSpot here

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15955#issuecomment-1785425910

Reply via email to