On Wed, 1 Nov 2023 11:19:20 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains >> all of the fixes required for HotSpot to compile under the stricter mode >> activated when the permissive- flag is passed >> >> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to >> avoid goto jumping across uninitialized locals >> - Adds a CAST_FROM_FN_PTR cast to the return value from ::signal to void, as >> they cannot be implicitly converted >> - symbolengine.cpp's SimpleBufferWithFallback's templates cannot work with a >> raw char (Actual fix under discussion) >> - Removed a throw() specification from a mismatched definition in >> allocation.cpp > > Julian Waters has updated the pull request incrementally with two additional > commits since the last revision: > > - Formatting os_windows.cpp > - Duplicate return statement instead in os_windows.cpp With this, the reign of non-conforming HotSpot code on Windows comes to an end :) Will wait for the tests to pass before integrating ------------- PR Comment: https://git.openjdk.org/jdk/pull/15955#issuecomment-1788791820
