On Wed, 1 Nov 2023 11:52:20 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi, please consider. >> >> insn_options[0] is set to empty string if there is no options (NULL or empty >> strings). >> Checking it for empty string should cover both cases, caller option is NULL >> or caller option is empty string. >> >> Tested hsdis no longer gives me the warning. > > Robbin Ehn has updated the pull request incrementally with one additional > commit since the last revision: > > More clear LGTM, Thanks. ------------- Marked as reviewed by mli (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16433#pullrequestreview-1708250640
