On Tue, 31 Oct 2023 21:32:26 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:

> hb-subset and hb-style APIs are not used and not exported by libfontmanger. 
> We can cut the compilation time by not compiling the unused files.
> 
> The added exclusions reduce the build time by ~1 minute (~8%) on my machine. 
> This is with harfbuzz 8, with harfbuzz 7 the improvement was ~30 seconds.
> 
> Client libs tests continue to pass.

Looks good to me.

You may want to wait for Phil's approval though.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16440#pullrequestreview-1708815489

Reply via email to