On Thu, 2 Nov 2023 03:32:14 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Prepare HotSpot for the permissive- Visual C++ flag, this change contains >> all of the fixes required for HotSpot to compile under the stricter mode >> activated when the permissive- flag is passed >> >> - Reworks code in topLevelUnhandledExceptionFilter for os_windows.cpp to >> avoid goto jumping across uninitialized locals >> - Adds a CAST_FROM_FN_PTR cast to the return value from ::signal to void, as >> they cannot be implicitly converted >> - symbolengine.cpp's SimpleBufferWithFallback's templates cannot work with a >> raw char (Actual fix under discussion) >> - Removed a throw() specification from a mismatched definition in >> allocation.cpp > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Try immediate bailout in os_windows.cpp Changes requested by dholmes (Reviewer). src/hotspot/os/windows/os_windows.cpp line 2915: > 2913: goto result; > 2914: } else { > 2915: DWORD exceptionCode = exceptionInfo->ExceptionRecord->ExceptionCode; No you brought the goto back! Why? goto's are bad. ------------- PR Review: https://git.openjdk.org/jdk/pull/15955#pullrequestreview-1709483962 PR Review Comment: https://git.openjdk.org/jdk/pull/15955#discussion_r1379614868