On Thu, 9 Nov 2023 16:07:53 GMT, Mikael Vidstedt <[email protected]> wrote:
> This PR is splitting out the GCC 13.2.0 warning related changes from #16550, > excluding the Oracle/devkit parts, for clarity and to make potential > backports more straightforward. > > GCC 13.2.0 generates two new warnings: > > * linux-aarch64-debug > > src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp:203:66: error: > 'long unsigned int __atomic_load_8(const volatile void*, int)' writing 8 > bytes into a region of size 0 overflows the destination > [-Werror=stringop-overflow=] > > I did not find any way to adjust the code to avoid this warning, so I instead > chose to disable it in `CompileJvm.gmk` for linux-aarch64-(fast)debug only. > > * linux-zero > > src/hotspot/share/runtime/thread.hpp:579:77: error: storing the address of > local variable 'rm' in '*_thr_current.Thread::_current_resource_mark' > [-Werror=dangling-pointer=] > > Lots and lots of warnings related to ResourceMark. Thanks to @stefank for > suggesting moving the ASSERT implementation of the ResourceMark constructor > to the .cpp file. With that change there's no need to explicitly disable the > warning. Build changes look fine. So you want the split to be more in lines of "what Oracle needs" and "what is needed to compile with gcc 13.2". I see. It sounds reasonable when you put it that way. :) ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16584#pullrequestreview-1723749487 PR Comment: https://git.openjdk.org/jdk/pull/16584#issuecomment-1804901112
