On Thu, 16 Nov 2023 17:25:58 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request with a new target base due 
>> to a merge or a rebase. The incremental webrev excludes the unrelated 
>> changes brought in by the merge/rebase. The pull request contains three 
>> additional commits since the last revision:
>> 
>>  - Merge branch 'master' into readme-locale
>>  - Update wording according to review suggestion
>>  - 8264425: Update building.md on non-English locales on Windows
>
> doc/building.html line 404:
> 
>> 402: locale for a specific process like this in Windows. The only way is to
>> 403: change the user locale setting to <strong>US English</strong>, which
>> 404: will affect all applications run by the user.</p>
> 
> IIUC, it is not only the user locale, but also the system locale that derives 
> the file path encoding should be set to US English (using the `UTF-8` beta 
> option may help though)

Oh, here are lots of news to me.

1) What is the system locale? How do you check which locale is the system 
locale (as opposed to the user locale), and how to you change it?

2) What is the UTF-8 beta option?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16694#discussion_r1397269716

Reply via email to