On Sun, 19 Nov 2023 08:45:29 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 
>> 34:
>> 
>>> 32:     <group id="javadtds" prefer = "system" xml:base = "java/dtd/">
>>> 33:         <system systemId="http://java.sun.com/dtd/preferences.dtd"; 
>>> uri="J2SE/preferences.dtd"/>
>>> 34:         <system systemId="http://java.sun.com/dtd/properties.dtd"; 
>>> uri="J2SE/properties.dtd"/>
>> 
>> Would it be possible to provide a summary on how the relative uri in the 
>> "uri" attribute is handled? Asking as it's not clear to me how the decoding 
>> is handling, meaning this is a relative URI, not a relative file path.
>
> Can we move DTD in the JDK's catalog to a "Java" or "JavaSE" directory, only 
> because "J2SE" feels a bit yesterday.

Thanks Alan. Removed “J2SE”. Added a note explaining how the DTDs are resolved. 

In early prototypes, the Catalog contained 7 sub-groups in the java/dtd group, 
including J2SE and J2EE, names came from their original places where these DTDs 
were defined.

You're right, now that the built-in catalog contains only DTDs defined in the 
Java platform, it makes sense to keep just the java/dtd group.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1398519536

Reply via email to