On Tue, 21 Nov 2023 14:13:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Yes, it seems weird. But the library we want to built out is `libvmath.so` >> instead of `libsleef.so`. And we not only check the sleef library, but also >> the ARM SVE feature inside it. So using `VMATH` suffix is more reasonable to >> me. WDYT? > > As I said above, you should not mix the two together. Keep the library > handling for libsleef. Move the march setting to where it belongs. And rename > the files, functions and variables after this. OK, I see. It makes sense that the suffix name should be choosed mainly based on the real module name that is searched/checked in configure. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1402847627
