On Thu, 23 Nov 2023 09:19:11 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> Galder Zamarreño has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. The pull request >> contains two new commits since the last revision: >> >> - 8320533: Use autoconf to select the right capstone arch name >> - 8320533: Update capstone aarch64 integration >> >> * `CAPSTONE_ARCH` for aarch64 is now `CS_ARCH_AARCH64` instead >> of `CS_ARCH_ARM64`. >> * The `-Daarch64` macro was getting in the way >> and was causing invalid C to be produced. >> Undefined it before including `capstone.h`. > > src/utils/hsdis/capstone/hsdis-capstone.c line 54: > >> 52: #include <inttypes.h> >> 53: #include <string.h> >> 54: > > Need a comment about this `undef` Added a comment. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16788#discussion_r1403582788
